[Bug 175748] Review Request: cacti

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cacti


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175748





------- Additional Comments From gauret at free.fr  2005-12-18 13:03 EST -------
> I ended up taking the mail out of the RPM all together, I don't
> remember getting emails from other packages saying "hey configure me here"

Agreed. Seemed "unnatural" to me too.

> I've taken the database config portion out of the config.php file and placed
> it in /etc/cacti/db.php  It seems like nothing else in config.php would need
> to be edited for normal use.

Very nice. There are a few additional config vars for some HTML colors in
config.php, but we can ignore this. Actually, I wish upstream had splitted the
db config out of config.php. Could you submit your patch upstream (with the
/etc/cacti/db.php paths replaced by include/db.php) ?

A few last things :
* remove /sbin/service from Requires (it's already in Requires(postun))
* in %install, first you %__install the .placeholder file, then you empty it
  with echo. Why ? I think that is file is here just to prevent winzip from not
  including the rra dir, so you should not bother about it (I think you can even
  remove it entirely).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.