[Bug 165955] Review Request: grads Grid Analysis and Display System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grads Grid Analysis and Display System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165955





------- Additional Comments From ed at eh3.com  2005-12-19 11:55 EST -------
Hi Patrice, I grabbed grads-1.9b4-4.src.rpm and took a closer look:

good:
 + source "matches" upstream in the sense that you've clearly spent a 
   lot of time carefully extracting only the files that have Fedora-
   compatible licenses and included them in a tarball derived from the 
   upstream tarball (and your extraction script for the un-ship-able 
   files was helpfully provided)
 + licenses are a mess but you've obviously put a lot of effort into 
   tracking down the licenses for every file that matters and have 
   correctly removed the ones that can't be in Extras
 + spec is legible and contains no obvious problems
 + builds in mock on FC-4
 + rpmlint reports:
     W: grads wrong-file-end-of-line-encoding \
        /usr/share/doc/grads-1.9b4/html/reference_card.pdf
     W: grads wrong-file-end-of-line-encoding \
        /usr/share/doc/grads-1.9b4/html/GrADS.css
     W: grads wrong-file-end-of-line-encoding  \
        /usr/share/doc/grads-1.9b4/html/reference_card_scl.pdf
   whiche are all ignore-able warnings
 + I installed and ran a few of the binaries and they worked 
   nicely--exactly per the tutorial

Congrats on beating this old software into an Extras package.  It 
doesn't look like the licensing was any fun to sort out.  In fact, 
the upstream maintainers are clearly linking together software with 
incompatible licenses and perhaps don't realize or even care.  Maybe 
they can contact the origianl authors (eg. Arlindo da Silva who is 
still apparently working at NASA Goddard) and get (some?) of the 
licenses changed so that more can be shipped.

In any case, I don't see any remaining blockers so its APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.