[Bug 169927] Review Request: scim-fcitx - Chinese IMEngine for SCIM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scim-fcitx - Chinese IMEngine for SCIM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169927


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-19 16:13 EST -------
The careful review is mostly thanks to the fedora-qa script.

rpmlint
- rpmlint of scim-fcitx: Missing changelog entry, minor
- rpmlint of scim-fcitx-tools: No docs, ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


Note that I have not tested using this.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.