[Bug 176096] Review Request: gentium-fonts: SIL Gentium fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gentium-fonts: SIL Gentium fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176096





------- Additional Comments From mpeters at mac.com  2005-12-20 14:47 EST -------
I would make two recommendations -

1) ass the following:

Obsoletes: fonts-sil-gentium
Provides: fonts-sil-gentium

Reason: upstream provides an rpm with that name.

It's up to you, but if upstream provides an rpm then I think it generally best
to make sure that the Fedora rpm provides the same name.

2)

I *think* you need to change

if [ -x %{_bindir}/fc-cache ]; then
  %{_bindir}/fc-cache %{_datadir}/fonts
fi

to

if [ -x %{_bindir}/fc-cache ]; then
  %{_bindir}/fc-cache %{_datadir}/fonts/gentium
fi

I seem to remember the fonts.cache-2 file not being properly created in FC5 when
fc-cache is run on the %{_datadir}/fonts instead of the directory containing them.

3) I personally would get rid of

%define fontdir         %{_datadir}/fonts/gentium

Just use %{_datadir}/fonts/gentium

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.