[Bug 174181] Review Request: python-simpy Python simulation framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-simpy Python simulation framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174181


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2005-12-21 00:22 EST -------
SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires:
tkinter needed.

The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one
or the other. file says "python-simpy.spec: lex description text"

Follows python spec template

- rpmlint does not output anything

I would not call this python-simpy, simpy is sufficient, as it is not a python
extension but a SIMulation in PYthon. Debian seems to call it python-simpy,
however. Your choice.

You removed the source documentation. Consider packaging it as a seperate docs
subpackage.

The patch removes all shebangs. Why, is this to quiet rpmlint?

- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386, is noarch
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.