[Bug 173181] Review Request: buoh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: buoh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173181





------- Additional Comments From wart at kobold.org  2005-12-21 11:26 EST -------
Just a couple of comments:

The line
rm -rf $RPM_BUILD_ROOT
should be at the start of %install, not at the end of %prep.

The line
unset GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL
shouldn't be necessary since each rpm section executes in a separate shell
script.  Env. variables set in one section aren't preserved in the next.

I notice that it requires gtk-2.7.  This is newer than the gtk-2.6.10 provided
by FC-4.  Do you plan to package this for FC-4, or just devel?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.