[Bug 176374] Review Request: nagios-plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176374


paul at xtdnet.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at xtdnet.nl




------- Additional Comments From paul at xtdnet.nl  2005-12-21 21:56 EST -------
I have a few questions and comments (though I don't have the power to aprove or
reject your package):

- Why do you use /var/lib/nagios?  Since these are all standard scripts and not
machine specific data, i would put them in /usr. They can be shared by many
machines after all, and that is what /usr I think still intends to be.

- Would it make sense to give nagios a homedir? Most people will want to call
those scripts using a central nagios-server running plugins through
check_via_ssh. I prefer not to have the scripts *writable* by the nagios user,
so a seperate directory in /usr/lib/nagios, with files owned by root, and a
seperate nagios homnedirectory for its .ssh dirctory with authorized_keys.

- I know there is also a nagios-extras plugin set. Would it make sense to split
out all these nagios checks in seperate packages? The advantage would be that
proper Requires: can be used. The disadvantage is the enormous overhead of
packaging and installing. Should we add the nagios-extras?

- I correctly did not cause dependancies on half the Core distro (debian did
when i apt-get install'ed nagios-plugins, installing things like mysql).

- What is the purpose of /etc/nagios/ and command.cfg ?

- Should Fedora reserve a UID/GID < 500 for nagios, so we can do additional
security like not allowing password logins or change of passwords, etc

- Add a Requires: net-snmp-perl? (see below)

- Are you planning to package oreon as well? 

- sourceforge urls are usually written as http://sourceforge.net/projects/%{name}/

- Use Release: 2%{?dist}

- don't use %define nagiosname, just decide (and use nagios)

- I was told to stick to make, not %{__make}. Same for rm and install.

- I would either use $RPM_BUILD_ROOT or (imho preferably) %{buildroot}, but not
both.

- how useful are check_ifoperstatus and check_ifstatus? Perhaps make the rm a
conditional on using/defining "with-net-smtp"? (and make requires: for that
ifdef'ed as well)

- I dont think the individual files/groups in
%{_localstatedir}/%{_lib}/%{nagiosname}/libexec/ need to be seperately added if
you add the directory already? (someone else verify this?)

- add the nagios user/group upon install? What I used (from my nsd rpm):
%pre
if getent passwd nagios >/dev/null 2>&1 ; then : ; else /usr/sbin/useradd -d
/home/nagios -r -s /bin/bash nagios >/dev/null 2>&1 || exit 1 ; fi

(note that AFAIK, it requires a valid login shell for check_ssh to work. If you
get an assigned UID/GID you can specify it in this commmand. The home directory
should probably go somewhere more reasonable. I tend to think nagios files
should be in /usr/lib/nagios and its homedir in /var/lib/nagios, but perhaps
there is a clearer Fedora policy on this that I am not aware of).







-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.