[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433





------- Additional Comments From kevin at tummy.com  2005-12-23 14:08 EST -------
>there is no big difference between the '%{?dist}' annotation and my
>%release_func. But the %release_func gives some more control over the
>resulting Release: and all of my packages are using it.

ok. No big deal there. ;) 

>>   and why a 1.2 release?

>Will become '2' at first CVS checkin. I just want to avoid
>release-inflation during the review.

ok. Reasonable. 

>> - minit and initng aren't in extras/core yet, might leave that out
>>   until they are added and then add support for those in?

>Both initstyles are disabled by default. But they are both used on my
>systems and 'initng' is under review (bug #173459) so it may appear
>soon at least in Extras.

Indeed, but they aren't currently in, so why add them now? You can re-add those
spec file bits and rebuild when/if they are included. Until then they are just
dead weight in the spec file. 

>> - Might fold the 'lsb' package into the main package? 

>I would like to avoid it. It brings lot of huge dependencies which are
>useless when you want to use 'tor' with 'initng' or 'minit'.

Yeah, but doesn't every other package in core and extras with an init.d script
already do that? I can't think of any other packages that have an init.d script
that package it seperately. Or am I just missing some dependency there? 

>> E: tor-lsb postin-without-chkconfig /etc/rc.d/init.d/tor
>> E: tor-lsb preun-without-chkconfig /etc/rc.d/init.d/tor
>> W: tor-lsb incoherent-init-script-name tor

>looks like bugs in rpmlint; the lsb initscript will be (un)registered
>properly and it is named 'tor'.

I think it's just mad because the package is 'tor-lsb' and the init.d file is
'tor'... 

Instead of the /etc/tor/.have-lsb, /etc/tor/.have-initng, /etc/tor/.have-minit, 
how about a '/bin/kill -HUP `cat /var/run/tor.pid 2>/dev/null` 2> /dev/null ||
true' (like httpd uses). That would work under any of those init schemes I would
think. 

With the ghostscript BR added, builds fine nuder mock. 

Works fine on my test machine. It's even not very slow for web browsing. :)

Thanks for working on this package... will be a good one to have. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.