[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-12-23 15:36 EST -------
* Fri Dec 23 2005 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.1.0.15-1.11
- reworked the 'setgroups' patch so that 'tor' survives a SIGHUP
- (re)added the 'reload' functionality to the lsb initscript and use
  it in logrotate

http://ensc.de/fedora/tor.spec
http://ensc.de/fedora/tor-0.1.0.15-1.11.src.rpm


===========


> >Both initstyles are disabled by default. But they are both used on my
> >systems and 'initng' is under review (bug #173459) so it may appear
> >soon at least in Extras.
> 
> Indeed, but they aren't currently in, so why add them now? You
> can re-add those spec file bits and rebuild when/if they are
> included. Until then they are just dead weight in the spec file.

When I would remove the -initng/-minit subpackages somebody would
probably ask why I have a single -lsb subpackage while no other init
methods are provided ;)


> >I would like to avoid it. It brings lot of huge dependencies which
> >are useless when you want to use 'tor' with 'initng' or 'minit'.
> 
> Yeah, but doesn't every other package in core and extras with an
> init.d script already do that? I can't think of any other packages
> that have an init.d script that package it seperately. Or am I just
> missing some dependency there?

I really want to avoid the bloaty initscripts/lsb; they add lot of
stuff which is unneeded and there is no chance to modularize this
package.

'initscripts' itself is not tight very much into the system; e.g. my
tor-vserver (with 'tor-minit') has it only because of

| $ LANG=C vrpm cheese -- -e --test initscripts 
| error: Failed dependencies:
|         initscripts >= 3.94 is needed by (installed) pam-0.79-9.6.i386
|         initscripts >= 8.11-1 is needed by (installed) hotplug-2004_09_23-7.i386

'hotplug' is brought in by 'initscripts' and I just submitted a bug
#176508 to remove the dependency in 'pam'.


> Instead of the /etc/tor/.have-lsb, /etc/tor/.have-initng,
> /etc/tor/.have-minit, how about a '/bin/kill -HUP `cat
> /var/run/tor.pid 2>/dev/null` 2> /dev/null || true' (like httpd
> uses).

Does not work because 'initng' and 'minit' do not need/provide a
pidfile. I find it also a little bit ... mmmh ... risky to send
signals to a foreign process just because its pid appears in some
file.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.