[Bug 169624] Review Request: TestDisk, tool to check and undelete partition

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TestDisk, tool to check and undelete partition


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169624


fedora at leemhuis.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at leemhuis.info
OtherBugsDependingO|                            |163778
              nThis|                            |




------- Additional Comments From fedora at leemhuis.info  2005-12-24 07:36 EST -------
>It's my first FC Extra package and I am seeking a sponsor.
I can do that. 

No full review yet, just the things I saw on a first sight:

--
Using these macros seems unnescaccary and confusing to me:

%define name    testdisk
%define ver     6.2
%define rel     1

You IMHO should remove them

--
Could you remove this:
#Packager:	Christophe GRENIER <grenier at cgsecurity.org>

--
Please change
BuildRoot:	%{_tmppath}/%{name}-%{version}-buildroot
to
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

--
The description is IMHO way to long. Why not something like:
Tool to check and undelete partition. Works with FAT12, FAT16, FAT32, NTFS, 
EXT2, EXT3, BeFS ....

And the question is wether ntfs is allowed to be supported if this porgramm hits
fedora extras. What exactly does it to support NTFS? Could is be in conflict
with patents around NTFS?
  
--
during configure I noticed:
>checking for ntfs_device_mount in -lntfs... no
>configure: WARNING: No ntfs library detected
>checking for libreiserfs_get_version in -lreiserfs... no
>configure: WARNING: No reiserfs library detected

Is that correct? There are several other checks that result in "no" -- Could you
check if they can be ignored safely?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.