[Bug 169624] Review Request: TestDisk, tool to check and undelete partition

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TestDisk, tool to check and undelete partition


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169624





------- Additional Comments From fedora at leemhuis.info  2005-12-24 10:42 EST -------
(In reply to comment #3)
> I have updated the spec file according to your remarks.

And you did not increase the Release -- please do this the next time. That's
easier and avoids confusion, even during review.

> Be supporting NTFS, it only means TestDisk can decode the NTFS boot sector,
> it doesn't mean it can read/write NTFS partition.

That might be okay. But I'll recheck with Fesco/Legal.

> ntfs and reiserfs library aren't shipped in fedora. TestDisk can work without
> them, they are only necessary if you want to be able to list the files from
> ReiserFS 3.5/2.6 and NTFS partition.
Okay.

> It's not a problem if there are a lot of "no" during configure.

Sure, I just wanted to be sure that you checked them. ;-)

One other thing I just noticed that I'm not sure about myself. The spec file has:
%doc %{_mandir}/man1/testdisk.1*
%doc %{_mandir}/man1/photorec.1*

Uhh, do we ship man pages as doc? To answer my own question: Seems we sometimes
do according to a grep through a extras cvs checkout
[rpmbuild at truhe devel]$ grep /man./ */*.spec  | grep \%doc | wc -l
35
[rpmbuild at truhe devel]$ grep /man./ */*.spec   | wc -l
1071

@fedora-extras-list: Any option on this? IMHO man pages should not be marked as
%doc. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.