[Bug 173181] Review Request: buoh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: buoh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173181


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |bugs.michael at gmx.net
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2005-12-25 11:18 EST -------
* Fails to build here (FC4):

RPM build errors:
    File not found: /home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh
    File not found: /home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh/comics
    File not found: /home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh/ui
    File not found:
/home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh/comics/comics.xml
    File not found by glob:
/home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh/pixmaps/buoh*.png
    File not found:
/home/qa/tmp/rpm/tmp/buoh-0.8.1-1-root-qa/usr/share/buoh/ui/buoh-ui.xml

Examining the buildroot, it installed into /usr/buoh instead of /usr/share/buoh.

* Remove the hardcoded list of "Requires", because in this case all of
them ought to be left to RPM's automatic SONAME dependencies.

To verify, run "rpm --query buoh-0.8.1-1.i386.rpm" and notice dependencies
like libgconf-2.so.4, libgtk-x11-2.0.so.0, libsoup-2.2.so.7, libgnomeui-2.so.0.
Package tools know in which RPM packages to find those library names.

* Missing %postun scriptlet, which runs ldconfig and which uninstalls
the GConf schema files with --makefile-uninstall-rule.

* Missing  "Requires(post): /sbin/ldconfig GConf2" and "Requires(postun):
/sbin/ldconfig GConf2", particularly since /usr/bin/gconftool-2 must
still be installed before the package would be uninstalled.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.