[Bug 176205] Review Request: GZLauncher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GZLauncher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176205





------- Additional Comments From jpmahowald at gmail.com  2005-12-26 21:10 EST -------
Still a couple minor things to fix.

Change Source1 to merely gzlauncher.desktop, by default rpm looks in the sources
dir.

%{_datadir}/gzlauncher/*  does not own the directory %{_datadir}/gzlauncher/
itself.  %{_datadir}/gzlauncher/ will own the directory itself.

Segfault bug submitted.
http://sourceforge.net/tracker/?func=detail&atid=667062&aid=1390964&group_id=114060

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.