[Bug 173181] Review Request: buoh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: buoh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173181


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From bugs.michael at gmx.net  2005-12-27 07:40 EST -------
Okay. Looked into it. When "gettext" is not installed, the configure
script defines $DATADIRNAME as empty instead of "share". I believe
gettext is in mock's default build environment, but I would suggest
adding it nevertheless as a build requirement.

Remaining issues:

 * No desktop menu icon. It's installed into a private directory
  (/usr/share/buoh/pixmaps) which is not searched in by the desktop
  environment.

 * .desktop file ought to be installed with desktop-file-install 
  (BuildRequires: desktop-file-utils) and
  - should include category "X-Fedora"
  - Terminal=false instead of Terminal=0 according to freedesktop standard
    (run desktop-file-validate on the file to see)

Run-time observation:

 * Menu "Help > Contents" doesn't do anything.


Else it seems to work. You may fix the desktop menu issues
within Fedora Extras CVS.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.