[Bug 174265] Review Request: itcl - Object oriented extension to Tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: itcl - Object oriented extension to Tcl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174265





------- Additional Comments From wart at kobold.org  2005-12-28 19:57 EST -------
(In reply to comment #1)
> * Why not package the itk extensions seperately? tcl and tk are seperate.

Tcl and Tk are built from separate source archives, while itcl/itk use a single
source tarball for both packages.  This gives me two choices if they are to be
packaged separately:

- Create two spec files that point to the same source tarball so that the
package names (itcl, itk) can be preserved
- Create itk as a subpackage so that only one copy of the source tarball is
needed:  itcl, itcl-itk

I'm leaning towards the second approach, even if it doesn't preserve the
upstream package name.  Using the same source tarball in two packages seems
awkward and error-prone.

> * Source 0 is not available
> (http://sourceforge.net/project/incrtcl/itcl3.2.1_src.tgz)
>   (wiki: QAChecklist item 2)
> It seems the only way to enable automated sourceforge downloads is to hard code
> a mirror.

I'll fix this in the next spec file.

> * 3.3 seems to have been released.

3.3 is still a release candidate, and has build problems on Linux. 
Additionally, the 3.3 release breaks the iwidgets package, which is the main
reason that I'm packaging itcl to begin with.  Once itcl 3.3 works with iwidgets
then I'll upgrade.

> * Some compiler warnings, mostly about pointers, that you may want to inform
> upstream about.

Will do.

> * To clarify, the large patch included is to update configure, respect DESTDIR,
> look in lib64, etc.? May go upstream, possibly saving 100KB from the srpm!

Correct.  I'll notifiy upstream so that this makes it into the 3.3 final release.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.