[Bug 176591] Review Request: php-json: An extremely fast PHP extension for JSON

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 29 12:19:08 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-json: An extremely fast PHP extension for JSON


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176591





------- Additional Comments From dmitry at butskoy.name  2005-12-29 07:19 EST -------
> Except when mock does its depsolving.
Not understood how mock can have issues here, but it is not a blocker :)

> I always add that once it's in CVS.
Why not before? IMO the PackageGuidelines requires it at review stage... Anyway,
all other guys do it before CVS... 

- installed pam-json.html has execution bit set. Actually, "x" bit is set
immediately after "install -p %{SOURCE1}". Perhaps changing "install" to "cp"
can solve this.

- Initially, I resisted to increase release numbers after each trivial change.
But eventually various reviewers have forced me to do it always... ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list