[Bug 176733] New: Review Request: php-pear-DB (PEAR database abstraction layer)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176733

           Summary: Review Request: php-pear-DB (PEAR database abstraction
                    layer)
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: gdk at redhat.com
        ReportedBy: bugs at timj.co.uk
         QAContact: dkl at redhat.com
                CC: fedora-extras-list at redhat.com


Spec Name or Url: http://www.timj.co.uk/linux/specs/php-pear-DB.spec
SRPM Name or Url: http://www.timj.co.uk/linux/srpms/php-pear-DB-1.7.6-1.src.rpm
Description:
PEAR DB is a database abstraction layer for PHP.

This package actually used to be provided by the old php-pear subpackage of PHP. It was (sensibly) dropped from that as a result of bug #173808 but as a consequence it means that this package should perhaps ultimately be moved to Core rather than Extras.

This package is testing the water as far as PEAR modules and Fedora Extras go; if this review goes OK it would be nice to get more PEAR packages into FE and to that end I have been working on getting the PHP/PEAR packages in Core to a state where this is easier to do (see bug #176725, bug #173804, bug #173806, bug #173810, bug #173814, bug #173270 and related bugs). My ultimate goal is that "pear makerpm" (at least as supplied by Fedora) should build FE-compatible spec files "out of the box" (or as close to it as possible). This is not yet the case, even with all the patches I've supplied, but the feedback from this bug will be useful in developing further patches towards that goal.

Some particular notes:

1. The package uses the new naming convention as defined by Joe Orton in bug #173806, i.e.:

Name: php-pear-DB
Provides: php-pear(DB) = 1.7.6

2. With the above in mind, the spec file has at least one nod to automated generation: the %files section is populated predominantly by "/".  This does result in the package owning lots of directories it doesn't actually need to; it doesn't cause any practical problems that I'm aware of but if it irks anyone then I will have to re-think things.

3. As a new FE contributor, I've been a bit confused about the whole license-file-in-package debate. Upstream (by convention AFAICT) does not seem to explicitly include license files in any PEAR packages. In this package I have manually brought in the license file. I'd rather not do this if I can avoid it; do I have to?

This is my first FE package; I need a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.