[Bug 176733] Review Request: php-pear-DB (PEAR database abstraction layer)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-DB (PEAR database abstraction layer)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176733





------- Additional Comments From ivazquez at ivazquez.net  2005-12-31 07:07 EST -------
- Use "%define peardir %(pear config-get php_dir 2> /dev/null || echo
%{_datadir}/pear)" and BR php-pear instead of hardcoding %peardir
- Drop Source1
- Wipe %{buildroot} at the beginning of %install, not of %prep
- Do NOT use / in %files; be more explicit

(In reply to comment #0)
> 3. As a new FE contributor, I've been a bit confused about the whole
license-file-in-package debate. Upstream (by convention AFAICT) does not seem to
explicitly include license files in any PEAR packages. In this package I have
manually brought in the license file. I'd rather not do this if I can avoid it;
do I have to?

You do not have to bring in the license from an external source.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.