Review of pl package, big problems...

[Warren Togami]

Big looking failure here, why isn't the build aborting on failure?

gcc -c -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -Wall -fPIC 
-DHAVE_CONFIG_H -I/home/builder5/rpmbuild/BUILD/pl-5.4.5/include 
-I../../src -I../../src -DSWI -DHAVE_CONFIG_H pcecall.c -o 
../../src/pl/pcecall.o
gmake[4]: Entering directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/pl/src'
LD_RUN_PATH="/usr/lib:$LD_RUN_PATH"; \
         export LD_RUN_PATH; \
         /home/builder5/rpmbuild/BUILD/pl-5.4.5/src/plld -shared 
-L/usr/X11R6/lib -export-dynamic  -O3 -pthread 
../../src/pl/so-interface.o ../../src/pl/pcecall.o  -L../../src \
         -lXPCE /usr/lib/gcc/i386-redhat-linux/3.4.2/libgcc.a 
-L/usr/X11R6/lib -lXpm -ljpeg -lXt -lX11 -lSM -lICE  -o 
../../src/pl2xpce.so;
sh: pl: command not found
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `gcc -o ../../src/pl2xpce.so -shared 
../../src/pl/so-interface.o ../../src/pl/pcecall.o 
/usr/lib/gcc/i386-redhat-linux/3.4.2/libgcc.a -L(null)/lib/(null) 
-L/usr/X11R6/lib -L../../src -L/usr/X11R6/lib -lXPCE -lXpm -ljpeg -lXt 
-lX11 -lSM -lICE'
gcc returned code 512
*** /home/builder5/rpmbuild/BUILD/pl-5.4.5/src/plld exit status 1
gmake[4]: *** [axpce../../src/pl2xpce.so] Error 1
gmake[4]: Leaving directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/pl/src'
gmake[3]: *** [../../src/pl2xpce.so] Error 2
gmake[3]: Leaving directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/pl/src'
gmake[2]: *** [pl-itf] Error 2
gmake[2]: Leaving directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce'
gmake[1]: Entering directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/sgml'


Smaller failure here:

gmake[1]: Entering directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/cpp'
/usr/bin/install -c -m 644 pl2cpp.html 
/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/doc/packages
/usr/bin/install: cannot create regular file 
`/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/doc/packages': No 
such file or directory
gmake[1]: *** [html-install] Error 1
gmake[1]: Leaving directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/cpp'
gmake[1]: Entering directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce'


Then fails in a seemingly infinite loop, which would cause real trouble 
if we had an automated build system.

/home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/src/rel-ln 
/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/bin/i686-linux-gnu/pl 
/var/tmp/pl-5.4.5-1-root-builder5/usr/bin/xpce
./xpce-install -m 755 xpce-client /var/tmp/pl-5.4.5-1-root-builder5/usr/bin
/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/bin/i686-linux-gnu/pl \
           -F none \
           -f ../pl/src/plrc \
           -g 
"[library('man/man_index')],pce_make_manual_index('../man/reference/index.obj')" 
\
           -t halt
% /home/builder5/rpmbuild/BUILD/pl-5.4.5/packages/xpce/pl/src/plrc 
compiled into link_xpce 0.00 sec, 6,572 bytes
ERROR: 
(/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/xpce/prolog/boot/pce_principal.pl:104):
         pl2xpce: cannot open shared object file: No such file or directory
Warning: 
(/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/xpce/prolog/boot/pce_principal.pl:104):
         Goal (directive) failed: pce_principal: (initialization 
pce_host:$load_pce)
ERROR: exception handler failed to define predicate pce:object/1

ERROR: exception handler failed to define predicate pce:send/2

Warning: 
(/var/tmp/pl-5.4.5-1-root-builder5/usr/lib/pl-5.4.5/xpce/prolog/boot/pce_principal.pl:428):
         Goal (directive) failed: pce_principal: (initialization 
object(@prolog)->true;send(@host, name_reference, prolog))
ERROR: Exported procedure pce_principal:new/2 is not defined
ERROR: Exported procedure pce_principal:object/2 is not defined
ERROR: Exported procedure pce_principal:send_class/3 is not defined
ERROR: Exported procedure pce_principal:pce_method_implementation/2 is 
not defined
ERROR: Exported procedure pce_principal:get_class/4 is not defined
ERROR: Exported procedure pce_principal:in_pce_thread/1 is not defined
ERROR: Exported procedure pce_principal:pce_dispatch/1 is not defined
ERROR: Exported procedure pce_principal:get/3 is not defined
ERROR: Exported procedure pce_principal:pce_call/1 is not defined
ERROR: Exported procedure pce_principal:pce_end_dispatch/0 is not defined
ERROR: Exported procedure pce_principal:pce_open/3 is not defined
ERROR: exception handler failed to define predicate pce:send/2