Review of pl package, big problems...

[Warren Togami]

Gérard Milmeister wrote:
> On Fri, 2005-02-11 at 15:12 -1000, Warren Togami wrote:
> 
>>Big looking failure here, why isn't the build aborting on failure?
> 
> 
> Ok, I now have a (seemingly) working build. At least "manpce." works
> in the pl cli. However I think, that some testing would be in order.

Possible inconsistency in package.  Either disable it explicitly with a 
./configure option or add the BuildRequires.


checking for timegm... yes
ERROR:   Cannot find odbc library or the header sql.h
WARNING: ODBC interface will not be build
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h

Build failure ...

config.status: creating config.h
+ make 'COFLAGS=-O2 -g -pipe -m32 -march=i386 -mtune=pentium4'
for p in clib cpp odbc table xpce sgml sgml/RDF semweb http chr ssl; do \
     if [ -r $p/Makefile ]; then ( cd $p && gmake ); fi; \
         done
gmake[1]: Entering directory 
`/home/builder5/rpmbuild/BUILD/pl-5.4.6/packages/clib'
../plld.sh -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -Wall -fpic -I. 
-DHAVE_CONFIG_H   -c -o error.o error.c
error.c: In function `pl_error':
error.c:78: warning: unused variable `argn'
../plld.sh -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -Wall -fpic -I. 
-DHAVE_CONFIG_H   -c -o process.o process.c


Yikes, empty RPATH is very bad.  This must be fixed.

extracting debug info from 
/var/tmp/pl-5.4.6-1-root-builder5/usr/bin/xpce-client
12230 blocks
+ /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
ERROR: file '/usr/lib/pl-5.4.6/xpce-6.4.3/lib/i686-linux-gnu/pl2xpce.so' 
contains a standard rpath '/usr/lib' in [/usr/lib:]
ERROR: file '/usr/lib/pl-5.4.6/xpce-6.4.3/lib/i686-linux-gnu/pl2xpce.so' 
contains an empty rpath in [/usr/lib:]
error: Bad exit status from /var/tmp/rpm-tmp.51872 (%install)

https://www.redhat.com/archives/fedora-extras-list/2005-February/msg00295.html
Please follow the instructions here to add check-buildroot and 
check-rpaths to your rpmbuild.

Warren Togami
wtogami at redhat.com