[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: new package for review: logjam



On Thu, 2005-02-10 at 01:16 +0100, Michael Schwendt wrote:
> On Wed, 09 Feb 2005 17:23:34 -0600, Tom 'spot' Callaway wrote:
> 
> > Just imported: logjam
> > 
> > Logjam is a gtk2 client for LiveJournal.com. I've been maintaining RPMS
> > for this package since Red Hat Linux 7.3 was the current release.
> > 
> > Please review, according to the Interim New Package Process.
> 
> Had a brief look only:
> 
>  * First of all, rebuild failed for me. Last lines here:
> 
> make[1]: Leaving directory `/home/misc/tmp/rpm/BUILD/logjam-4.4.0'
> + /usr/lib/rpm/redhat/find-lang.sh /home/misc/tmp/rpm/tmp/logjam-4.4.0.root logjam
> No translations found for logjam in /home/misc/tmp/rpm/tmp/logjam-4.4.0.root
> error: Bad exit status from /home/misc/tmp/rpm/tmp/rpm-tmp.59001 (%install)

I can't reproduce this one... can you checkout the latest and try again?

Everything else I fixed, here's the changelog:
- use make, not %__make
- no need to export CFLAGS first
- BuildRequires aspell-devel, desktop-file-utils
- change PreReq to Requires
- delete $RPM_BUILD_ROOT first
- use desktop-file-install to install logjam.desktop
- nuke Vendor and Packager lines
- add patch to look for gtkhtml3.1
- modify logjam.desktop to refer to X-Fedora-Extras
- add Comment and GenericName to logjam.desktop
- change Group to User Interface/Desktops

~spot
---
Tom "spot" Callaway <tcallawa(a)redhat*com> LCA, RHCE 
Red Hat Sales Engineer || Aurora Linux Project Leader

"If you are going through hell, keep going."
-- Sir Winston Churchill


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]