[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: new package for review: logjam



On Thu, 10 Feb 2005 10:45:18 +0100, Matthias Saou wrote:

> Tom 'spot' Callaway wrote :
> 
> > On Wed, 2005-02-09 at 20:08 -1000, Warren Togami wrote:
> > > Tom 'spot' Callaway wrote:
> > > > On Wed, 2005-02-09 at 19:54 -1000, Warren Togami wrote:
> > > > 
> > > > 
> > > >>Consider adding "%_smp_mflags  -j3" to your .rpmmacros, which
> sometimes 
> > > >>exposes Makefile races even on uniprocessor build machines.  Everyone
> 
> > > >>that does packaging should do this, in order to avoid a surprise
> failure 
> > > >>on a SMP build system.
> > 
> > Sneaking back on topic, with -j3, it still builds for me. I suspect the
> > missing gettext in the buildroot was what caused the translation error.
> 
> Yup. And Michael pointed that out in his first review mail : gettext-devel
> is most certainly the guilty one, and you'll need to add it to
> BuildRequires (as he wrote). Note that for RH/RHEL or FC < 3, it's
> "gettext" and not "gettext-devel" since the split happened very recently.

I must admit, I didn't look whether it needed gettext-devel or just
gettext. The former requires the latter, so...

Tom changed the BR to gettext in his last commit.

Based on reading his %changelog, it seems some comments on his package
have flown in via private communication channels. For the benefit of all
of us, please post such comments publicly, e.g. on fedora-extras-list,
so we can learn from them, too. Thank you.

-- 
Fedora Core release 3 (Heidelberg) - Linux 2.6.10-1.762_FC3
loadavg: 0.04 0.28 0.16


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]