Request for Review: xmlstartlet

[Ignacio Vazquez-Abrams]

On Wed, 2005-07-13 at 07:52 -0400, Daniel Veillard wrote:
> On Tue, Jul 12, 2005 at 06:39:21PM -0400, Ignacio Vazquez-Abrams wrote:
> > On Tue, 2005-07-12 at 05:53 -0400, Daniel Veillard wrote:
> > > If that renaming is done I would be okay to sponsor that package if needed.
> > 
> > Updated, with a note in %description.
> 
>   I started to look up more closely to teh spec file, there is a number
> of annoying things, sorry I didn't looked more closely in the first pass:
> 
>   BuildRequires: misses libxml2-devel
> I think 
>   Requires should at least list libxml2
> Why link against the static versions of the libraries ?
>   make EXTRA_LIBS="/usr/lib/libgcrypt.a /usr/lib/libgpg-error.a"
> Can't this check be done the normal way from configure ? 
> 
>   paphio:~ -> ldd /usr/bin/xmlstarlet
>         libz.so.1 => /usr/lib/libz.so.1 (0x00ae8000)
>         libm.so.6 => /lib/tls/libm.so.6 (0x00ef6000)
>         libpthread.so.0 => /lib/tls/libpthread.so.0 (0x00ce4000)
>         libdl.so.2 => /lib/libdl.so.2 (0x00deb000)
>         libc.so.6 => /lib/tls/libc.so.6 (0x00111000)
>         /lib/ld-linux.so.2 (0x00c3a000)
> 
> There is a big problem here: libxml2 is not referenced dynamically, it
>   should. I didn't looked at the MAkefile.am or configure but there
>   is something wrong: it should use xml2-config --cflags and 
>   xml2-config --libs to interface with libxml2. As a result it also 
>   link in -lpthread while this is actaully not needed anymore.
> 
> I think this is a bit too much to allow this in the current state to get
> in. It would be cool if you can get those fixed,

Fair enough. In that case I withdraw this package until further notice.

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050713/d542836a/attachment.sig>