Review: perl-Crypt-Blowfish / CBC

[Ville Skyttä]

On Thu, 2005-07-14 at 19:07 +0200, Andreas Thienemann wrote:
> On Thu, 14 Jul 2005, Ville Skyttä wrote:
 
> > > SPEC & SRPM: http://home.bawue.net/~ixs/perl-Crypt-Blowfish/
> > Need to own one more dir, honor $RPM_OPT_FLAGS, non-empty *.bs must not
> > be deleted, improve summary and description, trim build deps.  See
> > patch.
> Uhm. Sure about the non-empty stuff?

$ man DynaLoader
$ less /usr/lib/perl5/5.8.6/i386-linux-thread-multi/DynaLoader.pm
$ less /usr/lib/perl5/5.8.6/i386-linux-thread-multi/XSLoader.pm

On the other hand, I don't remember seeing a non-empty *.bs.

>  rpmlint complains about them and on 
> #fedora-extra I was advised to delete them.

That check should be just removed from rpmlint (added to my loooong
rpmlint TODO list).  It already checks for zero length files, which will
catch safely removable *.bs too.