Request for a sponsor and a review of: pam_abl

[Oliver Falk]

On 07/15/2005 11:14 AM, Tomas Mraz wrote:
> On Fri, 2005-07-15 at 09:46 +0200, Oliver Falk wrote:
> 
>>31,33c38,40
>>< install -D -m 644 conf/pam_abl.conf %{buildroot}/etc/security/pam_abl.conf
>>< install -D -m 755 tools/pam_abl %{buildroot}/sbin/pam_abl
>>< install -d -m 755 %{buildroot}%{_localstatedir}/lib/abl
>>---
>>
>>>install -D -m 644 conf/pam_abl.conf %{buildroot}/%{_sysconfdir}/security/pam_abl.conf
>>>install -D -m 755 tools/pam_abl %{buildroot}/%{_sbindir}/pam_abl
>>>install -d -m 755 %{buildroot}%{_localstatedir}/%{_lib}/abl
> 
> %{_sysconfdir} and %{_sbindir} begin with / already

Yes, correct. The / should be removed.

> And moreover the pam_abl binary should be probably installed in /sbin
> and not /usr/sbin as you suggest by using %{_sbindir}.

Any *good* reason for installing it in /sbin, rather than /usr/sbin?

> %{_lib} after _localstatedir is wrong - it expands to lib64 on 64bit
> arches.

Oops, yes, substitute problem.

>>44c51
>>< %config(noreplace) /etc/security/pam_abl.conf
>>---
>>
>>>%config(noreplace) /%{_sysconfdir}/security/pam_abl.conf
> 
> The same as above.

Yes, the slash should be removed.

>>46,47c53,54
>>< /sbin/pam_abl
>>< %{_localstatedir}/lib/abl/
>>---
>>
>>>%{_sbindir}/pam_abl
>>>%{_localstatedir}/%{_lib}/abl/

OK. Attached is the (slash-)corrected patch for Alexander.

Best,
  Oliver
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pam_abl.recom.spec
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050715/88e2c9c5/attachment.ksh>