Request for review: pygame
Ville Skyttä
ville.skytta at iki.fi
Sun Jul 17 10:53:15 UTC 2005
On Sat, 2005-07-16 at 19:04 -0400, Ignacio Vazquez-Abrams wrote:
> pygame: A set of Python modules designed for writing games
This was already discussed here a while back; without MPEG support (from
smpeg), pygame is more or less crippled. There's a "full featured" one
already available from rpm.livna.org (as python-pygame). Whether it
makes sense to ship a less featured one in Extras, dunno about this
specific case. In general I don't think so. If you disagree, this
package could use some work:
- Missing BuildRequires: python-devel
- Unnecessary explicit Requires: SDL_*
- Missing dependencies in -devel: SDL-devel, SDL_ttf-devel,
SDL_mixer-devel, python-devel
(For the following three, see eg. the rpm.livna.org specfile)
- Could use config.py for configuring instead of shipping a hardcoded
"Setup" (with h/c'd "/usr/lib" and "python2.4" paths etc)
- Could perhaps run the test suite in %check
- Could ship the docs in a separate "-doc" subpackage, and add examples
to it
More information about the fedora-extras-list
mailing list