Request for review : gkrellm-bmp

[Matthias Saou]

Michael Schwendt wrote :

> The "Conflicts" in there are unacceptable. gkrellm-xmms may obsolete and
> provide gkrellmms in the usual way. But gkrellm-bmp must not use the same
> file name for its plugin and locale files than gkrellm-xmms. If upstream doesn't like to rename the plugin, you could do it, e.g.: gkrellmms-bmp.so

Sure. Is the PACKAGE= override during "make install" enough to get the
plugin to use the right translations, though? Seems surprising to me.
Doesn't it also need it during the actual compile stage? Sorry if this
seems like a silly question :-)

Matthias

> --- gkrellm-bmp.spec.orig       2005-07-19 18:40:43.000000000 +0200
> +++ gkrellm-bmp.spec    2005-07-19 18:44:55.000000000 +0200
> @@ -41,18 +41,21 @@
>  %{__make} install \
>      DESTDIR="%{buildroot}" \
>      PLUGIN_DIR="%{gkplugindir}" \
> +    PACKAGE="gkrellmms-bmp" \
>      enable_nls=1
> -%find_lang gkrellmms
> +mv %{buildroot}%{gkplugindir}/gkrellmms.so \
> +    %{buildroot}%{gkplugindir}/gkrellmms-bmp.so 
> +%find_lang gkrellmms-bmp
>  
>  
>  %clean
>  %{__rm} -rf %{buildroot}
>  
>  
> -%files -f gkrellmms.lang
> +%files -f gkrellmms-bmp.lang
>  %defattr(-, root, root, 0755)
>  %doc Changelog FAQ README
> -%{gkplugindir}/gkrellmms.so
> +%{gkplugindir}/gkrellmms-bmp.so
>  
>  
>  %changelog

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 4 (Stentz) - Linux kernel 2.6.12-1.1398_FC4
Load : 1.94 2.54 1.95