Request for sponsor and review of: lazarus and fpc

[Orion Poplawski]

Joost van der Sluis wrote:
> Hi all,
> 
> Some time ago Jens Petersen helped me a lot with creating a package for
> freepascal (fpc 2.0.0) but I didn't succeed to find a sponsor thus far.
> 
> In the meantime an IDE which works with freepascal 2.0.0 is available.
> Maybe someone want to review the lazarus package, and even sponsor me so
> I can commit fpc and lazarus into the cvs.
> 
> Lazarus:
> 
> Lazarus is a free and opensource RAD tool for freepascal using the
> lazarus component library - LCL, which is also included in this package.
> 
> fpc:
> 

This is what I managed to review so far:

GOOD:

   - package name matches upstream.
   - GPL license and matches contents.

BAD:

  - spec file should be ftp.spec, no version. Release should probably be "1"
  - COPYING not included as %doc
  - Missing BuildRequires:  binutils, gpm-devel, some (la)tex package 
(may be others, I don't have mock setup)
  - why a "src" package? (Also note fpc-doc type in %desc).

%package src
Summary:        Free Pascal Compiler - sources
Group:          Development/Languages

%description src

The fpc-doc package contains the sources of Freepascal, for documentation or
automatical-code generation purposes.

You've already got a src.rpm.


POSSIBLY VERY BAD:

  - tar.gz of binary executables as part of the package!

MINOR:

  - Remove commented out *Requires: lines from spec