Request for review: gxemul
Jeff Spaleta
jspaleta at gmail.com
Fri Jul 29 03:57:40 UTC 2005
On 7/28/05, Tom 'spot' Callaway <tcallawa at redhat.com> wrote:
> SRPM:
> http://www.auroralinux.org/people/spot/review/gxemul-0.3.4-1.src.rpm
> SPEC:
> http://www.auroralinux.org/people/spot/review/gxemul.spec
good - builds in mock for fc4 x86
good - rpmlint gxemul-0.3.4-1.fc4.i386.rpm paases with expected disttag warning:
W: gxemul incoherent-version-in-changelog 0.3.4-1 0.3.4-1.fc4
good - follows naming guideline
good - license is included in docs
good - source matches upstream source
good - no unowned directories created
no locales to deal with.
no scriptlets by definition are sane scriptlets
I give you tentative approval. And I'll post to the commits list with
the required approval post no later than before I go to work tomorrow
barring any earch shattering events.
Any reason why you didn't just use the %configure macro?
-jef
More information about the fedora-extras-list
mailing list