Request for review: glpk

[Ed Hill]

On Thu, 2005-07-28 at 15:41 -0500, Quentin Spencer wrote:
> That's odd. I just tried downloading it and it worked. Anyway, another 
> octave user has hosted some of my RPMs before, so I put this on his FTP 
> server:
> ftp://coffee.phys.unm.edu/pub/dima/incoming/glpk-4.8-1.src.rpm


Hi Quentin,

Heres the promised glpk review:

 needswork:
 - a devel package should not install binaries -- please 
   put the binaries into a separate non-devel package
 - the package installs 19 headers in /usr/include and they 
   should probably be put in a subdirectory such as 
   /usr/include/glpk
 - please add an "rm -rf ${RPM_BUILD_ROOT}" immediately after 
   the "%install" line

 good:
 - name OK
 - source matches upstream
 - license OK
 - spec looks good
 - builds and installs for FC3
 - no errors from rpmlint
 - no shared libs and, despite Ralf's incessant emails,
     I wouldn't sweat this detail -- it will be nice to 
     eventually have shared libs (as you point out in the 
     spec-file) but in the mean time it is certainly not a 
     blocker for inclusion of this package into FE (it'll 
     probably require some cooperation with upstream?)
 - dir ownership OK
 - permissions OK
 - no *.la files
 - no segfaults from the binaries

So its mostly good and the few needswork items are easy to fix.

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464