Request For Review: lout (was Re: rpm package of lout)

[Ralf Corsepius]

On Thu, 2005-06-30 at 14:22 -0500, Tom 'spot' Callaway wrote:

> 
> New SPEC: http://www.auroralinux.org/people/spot/review/lout.spec
> New SRPM:
> http://www.auroralinux.org/people/spot/review/lout-3.30-2.src.rpm
> 
> Please re-review

Now, you're inconsistent with using directories. At some places you are
using /usr/bin etc., at others %{_bindir} ...

I'd propose this patch:

--- lout.spec.2 2005-07-01 02:20:32.000000000 +0200
+++ lout.spec   2005-07-01 02:20:58.000000000 +0200
@@ -42,13 +42,13 @@
 mkdir -p $RPM_BUILD_ROOT/%{_datadir}
 mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
 make DESTDIR=$RPM_BUILD_ROOT \
-     BINDIR=/usr/bin \
-     LIBDIR=/usr/share/lout \
-     DOCDIR=/usr/share/lout/doc \
-     MANDIR=/usr/share/man/man1 \
+     BINDIR=%{_bindir} \
+     LIBDIR=%{_datadir}/lout \
+     DOCDIR=%{_datadir}/lout/doc \
+     MANDIR=%{_mandir}/man1 \
      install installman installdoc
-cp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/%{name}/doc
-gunzip $RPM_BUILD_ROOT/%{_datadir}/%{name}/doc/user.ps.gz
+cp %{SOURCE1} $RPM_BUILD_ROOT/%{_datadir}/lout/doc
+gunzip $RPM_BUILD_ROOT/%{_datadir}/lout/doc/user.ps.gz

 %clean
 rm -rf $RPM_BUILD_ROOT

Another minor nit: There are traces of a lout-devel package inside of
the spec, but a *-devel package is not being built.

> (or approve).
Ahh! - Seems as if the approval policy has changed ...

Ralf