New Package: fish

[Oliver Falk]

On 06/30/2005 05:27 PM, Axel Liljencrantz wrote:
> On 6/30/05, Michael Schwendt <bugs.michael at gmx.net> wrote:
>>On Thu, 30 Jun 2005 16:12:20 +0200, Axel Liljencrantz wrote:
>>
>>
>>>>>http://roo.no-ip.org/fish/fedora/fish-1.11.1-8.src.rpm
>>>>
>>>>Repeating my earlier hint (%configure macro sets CFLAGS already, Makefile.in
>>>>adds the other flags, make target "all" is default):
>>>
>>>Hmm, you are right, that is done automatically. But your patch changes
>>>the CFLAGS part of the spec file back to the state it was in when I
>>>originally submitted the package. I was told to change the CFLAGS
>>>handling, and now I'm told to change it back to the way it was done in
>>>the first place. Is this a disagreement on how the spec file should
>>>look or an amusing method of confusing new packagers? :-o
>>
>>No, in your original packages you did _not_ use %configure.
> 
> 
> Of course. The third option: I am confused. Given how common an
> occurance it is, I really should learn to anticipate it.
> 
> http://roo.no-ip.org/fish/fedora/fish-1.11.1-9.src.rpm

Look OK for me now.

Best,
  Oliver