Request for review: perl-Number-Compare

[Michael Schwendt]

On Fri, 01 Jul 2005 13:39:22 +0100, Paul Howarth wrote:

> Michael Schwendt wrote:
> > On Fri, 01 Jul 2005 10:32:00 +0100, Paul Howarth wrote:
> > 
> > 
> >>- I'd put %check after %install rather than after %clean, so that builds 
> >>on rpm versions not supporting %check could still work.
> > 
> > 
> > Does order of spec sections matter? (I don't think so)
> 
> Current rpm versions run the %check scriptlet after %install, if %check 
> is present.

Regardless of where I put %check inside the spec? I can move the %files
section at the top of the spec. Could I do the same with %check or
%clean? ;)
 
> Older rpm versions don't understand %check, and will barf when they come 
> across it.

That was not the questions.
 
> If instead you have:
> 
> %install
> ...
> %clean
> ...
> %check || :
> ...
> 
> then old versions of rpm 

How old?

> will run the %check scriptlet at the end of the 
> %clean scriptlet, i.e. just after everything has been deleted. Not a 
> good idea.