Request for review: perl-Want

Oliver Falk oliver at linux-kernel.at
Fri Jul 1 13:17:09 UTC 2005


On 07/01/2005 01:05 PM, Oliver Falk wrote:
> On 07/01/2005 01:00 PM, Ralf Corsepius wrote:
> 
>> On Fri, 2005-07-01 at 12:36 +0200, Oliver Falk wrote:
>>
>>> On 07/01/2005 11:45 AM, Ralf Corsepius wrote:
>>>
>>>> On Fri, 2005-07-01 at 11:26 +0200, Oliver Falk wrote:
>>
>>
>>>> This would be a bit more general than what I use, but doesn't have any
>>>> impact on this package's behavior.
>>>
>>>
>>> It's just because the perl spec template does it this way, so I 
>>> recommend it as well!
>>
>> Let me put it this way: To me, all that matters is function.
>>
>> So, I am not going to adopt a template for stylish reasons, when I have
>> something that "appears to work" for years.
>>
>> If others feel "slavishly hanging on to templates is a good thing", I am
>> giving them "card blanche" to modify my perl-rpm-specs after cvs check
>> in.
> 
> It's your decision. :-)

* Builds fine
* Installs fine
* Uninstalls fine
* rpmlint is quiet
* %dist macro is allready in place

 From my point of view, it looks ok, apart from the not consistent 
identations :-)

Best,
  Oliver




More information about the fedora-extras-list mailing list