rpms/fish/devel fish.spec,1.1,1.2
Oliver Falk
oliver at linux-kernel.at
Fri Jul 1 14:21:57 UTC 2005
On 07/01/2005 04:10 PM, Michael Schwendt wrote:
> On Fri, 1 Jul 2005 07:08:36 -0400, Oliver Falk wrote:
>>Author: oliver
>>
>>Update of /cvs/extras/rpms/fish/devel
>>In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv10684
>>
>>Modified Files:
>> fish.spec
>>Log Message:
>>
>>- Added dist macro to the release
>>- Small spec beautifying
>
>
> Did you ask the packager for permission?
>
> We should not mandate spec formatting. Not only does it make cvs diffs
> really unreadable, formatting changes tend to come back as soon as the
> primary packager applies the next changes.
>
> This is really something that ought to stop. Reviews should focus
> on "must fix" issues. Tabs vs. spaces is not anything that improves
> package quality.
No, I didn't ask Axel, I imported it for him and rechecked if everything
is OK (and found the missing dist macro) and as I was checking I
believed it's much better readable if I add a few tabs. That doesn't
change functionality, but makes it easier for me to have an eye on the
package that I did approve... Be sure, that I will check the package in
future from time to time, just to be sure package quality is OK. :-)
And you are correct, it doesn't improve package quality, but specfile
readability. :-)
Best,
Oliver
More information about the fedora-extras-list
mailing list