ebtables (WAS: Re: Reviews still needed)

Oliver Falk oliver at linux-kernel.at
Fri Jul 1 15:04:44 UTC 2005


On 07/01/2005 03:54 PM, Tom 'spot' Callaway wrote:
> ebtables:
> https://www.redhat.com/archives/fedora-extras-list/2005-June/msg00704.html

TODO
* Don't include the INSTALL file in %doc section, as it is not of 
interesst for end-users and it contains wrong paths (eg /usr/local stuff).

OK
* Builds fine on FCdev i386 (don't know about x86_64)
* Installs fine
* Uninstalls fine
* Starting via initscript works
* License OK
* Source matches upstream
* install cleans out the build root
* clean exists
* No BuildRequires needed
* No need for subpackages
* Use of macros is consistant

Call it an approval, if you kick out the INSTALL file. :-)

Best,
  Oliver




More information about the fedora-extras-list mailing list