Request for review: pygsl

[Tom 'spot' Callaway]

On Fri, 2005-07-01 at 17:54 +0100, José Matos wrote:

> > - /usr/lib/python2.4/site-packages/pygsl is not owned by the package,
> > when it should be (again, this is a byproduct of using a filelist for
> > python packages, it will not mark directories, only files)
> > Adding this line to the %files entry should do the trick:
> > %dir %{python_sitearch}/pysql
> 
>   I think that it should be like Michael wrote:
> %{python_sitearch}/pysql/

If you're not using the filelist, yes. If you're using the filelist, you
just need to own the dir as well.

>   Ok, new version available:
> http://www.fc.up.pt/pessoas/jamatos/pygsl.spec
> http://www.fc.up.pt/pessoas/jamatos/pygsl-0.3.2-2.src.rpm
> 
>   And this I have verified that I have the right version. ;-)

Minor item in the new spec:

- You don't need two %setup lines. :)

Since thats such a minor (and easy fix), consider it APPROVED with that
change.

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!