Request for Approval: hdf5

[Ed Hill]

On Fri, 2005-07-01 at 09:57 -0600, Orion Poplawski wrote:
> Orion Poplawski wrote:
> > It compiles and tests fine on FC3, so perhaps it's a gcc 4.0.0 issue?
> > Not sure how easy it would be to cook up a small example that I could 
> > send to the gcc folks.
> > 
> 
> Fixed the bug in the hdf5 code so it compiles and checks clean now. 
> Will be submitting upstream.
> 
> Latest versions:
> 
> http://www.cora.nwra.com/~orion/fedora/hdf5-1.6.4-3.src.rpm
> http://www.cora.nwra.com/~orion/fedora/hdf5.spec
> 
> Please review (and/or approve)


Hi Orion,

Good:
 - source matches upstream
 - builds, installs, and seems to work correctly on FC-4
 - "make check" in the spec reported all tests as either
     PASSED or -SKIP- which looks good
 - *.la files have been cleaned up
 - can't find any other problems!

Perhaps (?) needs work:
 - rpmlint hdf5:
   - about a dozen %doc files have execute permissions set when
     they should probably be just 644
   - there are many zero-length Dependencies files in the docs 
     that rpmlint complains about but looking at the included 
     Makefiles it seems that they are actually used and parsed 
     and just need to be empty
   - a few end-of-line encoding warnings on %doc files but 
     they're HTML so would anyone care...?
 - rpmlint hdf5-devel:
   W: hdf5-devel no-provides hdf-devel
   W: hdf5-devel summary-not-capitalized hdf5 development files


Please fix the permissions and take a look at the warnings.  Since its
all just minor stuff, I'll send an approved message soon.

Ed


-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464