Request for review: ncview

[Quentin Spencer]

Ed Hill wrote:

>On Wed, 2005-07-06 at 11:01 -0500, Quentin Spencer wrote:
>  
>
>>OK, the packages builds and installs fine for me on FC3 (don't have a
>>FC4 system handy at the moment). The only rpmlint error I got was
>>something about non-binary stuff in /usr/lib. Investigating further, I
>>discovered that /usr/lib contains _only_ non-binary files, all of which
>>look like the sort of thing you might normally put in /usr/share. Was
>>this the intention of the original author? It also looks like maybe you
>>were trying to remove some of this with these lines in the spec:
>>rm -f ${RPM_BUILD_ROOT}%{_libdir}/*.ncmap
>>rm -f ${RPM_BUILD_ROOT}%{_libdir}/ncoverlay*
>>
>>However, these lines don't appear to do anything, as the files are all
>>located in /usr/lib/ncview/* rather than /usr/lib/*, and the ncoverlay*
>>files are actually nc_overlay*. If you don't want these in the package,
>>you could also use %exclude %{_libdir}/ncview* in the %files section.
>>(Or maybe NCVIEW_LIB_DIR=/dev/null in the makeinstall command? :) )
>>    
>>
>
>
>Hi Quentin & Orion,
>
>Thank you both for the reviews!
>
>I've done the following:
>
>  - with the one exception described below, moved all of the 
>      data files into /usr/share/ncview
>  - deleted the useless rm lines
>  - added COPYING to %doc
>  - added xorg-x11 Requires and xorg-x11-devel BuildRequires
>
>and heres the updated SRPM and spec:
>
>  http://mitgcm.org/eh3/fedora_misc/ncview-1.92e-3.src.rpm
>  http://mitgcm.org/eh3/fedora_misc/ncview.spec
>
>The exception noted above is /usr/lib/X11/app-defaults/Ncview which I'm
>fairly certain is in an acceptable location since its owned by the
>Required xorg-x11 and seems to be there for just that purpose.  But if
>it violates one of the Fedora packaging guidelines, please let me know
>and I'll happily move it.  ;-)
>  
>
Yes, this still gives that rpmlint error, but I think you're right.
Putting everything else in _datadir makes more sense to me. Consider it
approved.

-Quentin