Request for review: ncview

[Michael Schwendt]

On Wed, 06 Jul 2005 12:42:43 -0400, Ed Hill wrote:

>   http://mitgcm.org/eh3/fedora_misc/ncview-1.92e-3.src.rpm
>   http://mitgcm.org/eh3/fedora_misc/ncview.spec

It ignores $RPM_OPT_FLAGS.

It will fail to build on x86_64, because it hardcodes /usr/lib for
NetCDF.

It contains an executable manual page.

It prints a security relevant warning, which ought to be examined
closer:

/home/misc5/tmp/rpm/BUILD/ncview-1.92e/do_print.c:91: warning: the use of `tmpna
m' is dangerous, better use `mkstemp'

> %build
> cp Makefile.in Makefile.in.OLD
> cat Makefile.in | 

What does that do?

> %install
> export XAPPLRESDIR="${RPM_BUILD_ROOT}%{_libdir}/X11/app-defaults"

"rm -rf $RPM_BUILD_ROOT" is missing between those lines.

-- 
Michael Schwendt <mschwendt at users.sf.net>
Fedora Core release 5 (Development) - Linux 2.6.12-1.1413_FC5
loadavg: 2.14 2.14 1.56