Request for review: ncview

[Michael Schwendt]

On Wed, 06 Jul 2005 14:08:09 -0400, Ed Hill wrote:

> > It prints a security relevant warning, which ought to be examined
> > closer:
> > 
> > /home/misc5/tmp/rpm/BUILD/ncview-1.92e/do_print.c:91: warning: the use of `tmpna
> > m' is dangerous, better use `mkstemp'
> 
> I've written and added a patch that seems to do the right thing.

I would close the open file descriptor returned by mkstemp.

-- 
Michael Schwendt <mschwendt at users.sf.net>
Fedora Core release 5 (Development) - Linux 2.6.12-1.1421_FC5
loadavg: 1.01 1.19 1.39