Request for review: ncview

[Ed Hill]

On Fri, 2005-07-08 at 01:38 +0200, Michael Schwendt wrote:
> On Wed, 06 Jul 2005 14:08:09 -0400, Ed Hill wrote:
> 
> > > It prints a security relevant warning, which ought to be examined
> > > closer:
> > > 
> > > /home/misc5/tmp/rpm/BUILD/ncview-1.92e/do_print.c:91: warning: the use of `tmpna
> > > m' is dangerous, better use `mkstemp'
> > 
> > I've written and added a patch that seems to do the right thing.
> 
> I would close the open file descriptor returned by mkstemp.

OK, will do!

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464