Request for additional reviews of glabels.

Ralf Corsepius rc040203 at freenet.de
Fri Jul 8 04:27:30 UTC 2005


On Thu, 2005-07-07 at 17:54 -0400, Jeff Spaleta wrote:
> Now that glabels is in extras cvs, anyone have any additional comments
> before I request builds?
Two minor issues:

%doc %{_mandir}/man1/glabels.1*
The %doc on this line is redundant (files under %_mandir automatically
are docs).

%doc %{_datadir}/gnome/help/glabels/
I would not mark "help files" %doc, because references to them are not
unlikely to be hard-coded into the application. So, if a user installs
the package with "--excludedocs", he could end up with a broken
application (I haven't actually tried with this package).

Ralf





More information about the fedora-extras-list mailing list