Request for review / approval: mod_security.

[Oliver Falk]

Hi Michael!

On 07/08/2005 03:56 PM, Michael Fleming wrote:
> Hi folks,
> 
> I've undoubtedly put this one up before a while back, but I've made a couple
> of small changes and added some useful rules in the default config. 
> 
> Therefore I'm putting this up for further review and approval (I don't
> recall seeing much last time - I felt such a package would generate more
> interest :-)).
> 
> Name: mod_security
> 
> Summary: Security module for the Apache HTTP Server
> 
> Description:
> 
> ModSecurity is an open source intrusion detection and prevention engine for
> web applications. It operates embedded into the web server, acting as a
> powerful umbrella - shielding web applications from attacks.
> 
> SRPM:
> http://www.enlartenment.com/extras/mod_security/mod_security-1.8.7-2.src.rpm
> 
> Please have a look and feel free to send feedback or improvements.

You don't need an approval if the package was allready approved and is 
in cvs... Spec looks OK for me and and it seems you havn't change very 
much...

But OK, I'd like to mention a few things:
  - BuildRoot, as described in the PackagingGuidelines, pls.
    (http://fedoraproject.org/wiki/PackagingGuidelines).
    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

  - Why does the new package not depend on http(/-devel) >= 2.0.38, as 
the old package in CVS does?

  - Don't forget the %{dist} tag in the release, if you intend to cvs 
commit this.

  - setup can be written as setup -q (the -n modsecurity-%{version} is 
not needed)

Best,
  Oliver