nvu

[Christopher Aillon]

On 07/08/2005 10:25 AM, Matthias Saou wrote:

>Christopher Aillon wrote :
>
>  
>
>>>The only major blocker I saw was that without --disable-crypto, the build
>>>failed on FC4 i386, on a .h file which is identical to the one in the
>>>1.0.4 firefox tree, go figure.
>>> 
>>>
>>>      
>>>
>>Interesting -- got a build log?  Crypto is probably something we'd want 
>>to support here for pushing to some things such as krb5 realms, etc.  
>>(not sure if that's even an option in today's nvu, but still...)
>>    
>>
>
>Check the new nvu-1.0-0.1.i386-crypto-failed.log.gz here :
>
>http://ftp.freshrpms.net/pub/freshrpms/fedora/linux/testing/4/nvu/
>  
>
In file included from ../../../../dist/private/nss/nsspki1.h:57,
                 from nsspki.h:56,
                 from asymmkey.c:39:
../../../../dist/private/nss/oiddata.h:46: error: array type has 
incomplete element type

This was a bug in upstream's source, with the patch in firefox.  See 
https://bugzilla.mozilla.org/show_bug.cgi?id=284386

This brings up an interesting point in that some patches I used to have 
applied and then removed since they were upstreamed in the firefox 
branch may not have made it to the nvu branch :-(

Some really should go through and make sure that all the fedora patches 
in the firefox 1.0 series of packages (e.g. 1.0, 1.0.1, ... 1.0.4) have 
equivalent patches in the nvu package.  They exist for reasons.  This is 
the porting work that I mentioned earlier and may not be trivial.  The 
spec you provided is fairly easy to generate, its just not something I 
would have felt comfortable putting into extras as-is -- it should have 
the rest of the patches as well as I mentioned in my previous post.

>  
>
>>I'd suggest:
>>
>>Name=Nvu Web Authoring Tool
>>GenericName=Web Authoring Tool
>>    
>>
>
>OK, changed.
>
>  
>
>>Do we have all the pango patches we need to --enable-pango?  Not sure whether those made it into nvu's branch or not, but we should add them if not.  Especially so for rawhide, since the removal of xft caused text to not render properly in firefox without the latest patch in the rawhide RPM (firefox-1.0-pango-cairo.patch).
>>
>>You'll probably also need some of the patches requried to compile firefox on rawhide (the gcc4 patches, prdtoa patches, etc).
>>
>>I'll do a more formal review when you're ready.
>>    
>>
>
>Well, from my POV the package is "ready" since it builds fine on FC4 and
>runs fine based on the testing I've done. But checking made by people who
>know the problems that might be encountered (pango for instance), would be
>a good thing, so don't hesitate to do some testing, and comment :-)
>  
>
The firefox 1.0 version also builds with --enable-pango, but its not 
really functional.  You probably need the patches from the firefox 
version applied, those haven't been checked in on the 
FIREFOX_1_0_1_20050124_AVIARY_BRANCH yet and I doubt they made it into 
nvu's source (but I could be wrong).