Review: perl-ExtUtils-XSBuilder

[Ville Skyttä]

On Thu, 2005-07-07 at 15:33 -0500, Tom 'spot' Callaway wrote:

> perl-ExtUtils-XSBuilder:
> Modules that parse C header files and create XS glue code

Notes:
- Missing "Requires: perl(Tie::IxHash)" - not a hard dep, but for the
  module to be fully useful.  I don't think adding would cause problems.
- noarch package -> no need for CFLAGS or OPTIMIZE in %build
- No need to define perl_vendorarch or "|| :" after %check if you're
  targetting > FC2.
- Installs executable *.pm and *.pod -> easyfix:
  "find . -type f | xargs chmod -x" in %prep
- README contains copyright/licensing info, suggesting adding it.

Go ahead and import to CVS and fix what you find worth fixing of the
above, and I'll recheck.