Request for review: libxslt-plugin-regexp and libxslt-plugin-dates-and-times

[Ignacio Vazquez-Abrams]

On Fri, 2005-07-08 at 13:20 -0400, joel reed wrote:
> http://home.comcast.net/~joelwreed/libxslt-plugin-regexp.spec

- Versions in Requires, BuildRequires, and %description need to be fixed
up
- Either add "Requires(post): /sbin/ldconfig
\nRequires(postun): /sbin/ldconfig" or change the %post[un] lines to
"%... -p /sbin/ldconfig"
- Line spacing in %install and %files is odd
- Package doesn't own %{_libdir}/libxslt
! %description says that PCRE is required, but there's no BR for it
- %changelog entry is missing name/version at the end

> http://home.comcast.net/~joelwreed/libxslt-plugin-dates-and-times.spec

Same issues as above except s/PCRE/gcj/.

> Thanks for taking the time to review these plugins. At some point I'd
> need Fedora Extras CVS write access I guess. 

https://admin.fedora.redhat.com/accounts/

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050708/b2979aa7/attachment.sig>