Review: perl-ExtUtils-XSBuilder

[Tom 'spot' Callaway]

On Fri, 2005-07-08 at 20:02 +0300, Ville Skyttä wrote:
> On Thu, 2005-07-07 at 15:33 -0500, Tom 'spot' Callaway wrote:
> 
> > perl-ExtUtils-XSBuilder:
> > Modules that parse C header files and create XS glue code
> 
> Notes:
> - Missing "Requires: perl(Tie::IxHash)" - not a hard dep, but for the
>   module to be fully useful.  I don't think adding would cause problems.
> - noarch package -> no need for CFLAGS or OPTIMIZE in %build
> - No need to define perl_vendorarch or "|| :" after %check if you're
>   targetting > FC2.
> - Installs executable *.pm and *.pod -> easyfix:
>   "find . -type f | xargs chmod -x" in %prep
> - README contains copyright/licensing info, suggesting adding it.
> 
> Go ahead and import to CVS and fix what you find worth fixing of the
> above, and I'll recheck.

Made all the changes requested, except I left perl_vendorlib defined. I
wasn't sure if you meant that instead of perl_vendorarch or not.

Its in CVS.

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!