Request for review: keychain

[Alexander Dalloz]

Am Di, den 12.07.2005 schrieb Ed Hill um 4:10:

> Hi Alexander,

Hi Ed! Thanks for your review and comments.

> Hey, thats funny!  I've been referring people to those well-written IBM
> developerWorks articles on SSH:
> 
>   http://www-106.ibm.com/developerworks/linux/library/l-keyc2/

The article is a bit older, unfortunately, and things changed a bit with
keychain since its publishing.

> that are referenced from the main keychain web site but I never actually
> took the time to learn about or use keychain itself.  I just use ssh-add
> and ssh-agent.  Silly me!

keychain does not obsoletes both tools - it just makes their usage more
comfortable. I am sure you know that, just want to point that out again
for other readers.

> So heres a quick review of keychain which mostly looks good:
> 
> please fix:
>  - rpmlint complains:
>      W: keychain summary-not-capitalized agent manager ...

Changed.

>  - BuildRoot should be:
>      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>  - please add dist to version:  2.5.4.1%{?dist}

From guideline reading I found that the dist tag isn't mandatory and as
it is a noarch package I thought it would have been ok to omit the tag.
Changed it though.

Both the .spec and the src.rpm are renewed and available at:

http://www.uni-x.org/keychain.spec
http://www.uni-x.org/keychain-2.5.4.1-1.src.rpm

> Ed -- who doesn't want to become known as "that moron who said it was 
>       just dandy to include a security nightmare in Extras"  ;-)

Alexander


-- 
 
1024D/866ED681 2005-07-11 Alexander Dalloz (Fedora Project) <alex at dalloz.de>
Key fingerprint = CD40 0A91 7814 C1E4 5940  8E0E 1FD5 C316 866E D681

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050712/ce6e76b2/attachment.sig>