Request for review: gyrus

[Ralf Corsepius]

Hi Alexander,

partial review of your spec, without having tried to build your package:

On Tue, 2005-07-12 at 05:46 +0200, Alexander Dalloz wrote:
> gyrus: GNOME Cyrus-IMAPd Administrator
> 
> gyrus is a GNOME based tool for the administration of mailboxes in
> Cyrus-IMAPd servers. It allows to control user quotas, create and remove
> mailboxes, and to manipulate the Access Control List for each mailbox.
> 
> http://gyrus.gnome.cl/
> 
> At the moment gyrus isn't yet the tool it promises from summary. It may
> though be a help. 
> 
> Be touch to criticize this packaging:
> 
> http://www.uni-x.org/gyrus.spec

> Name:		gyrus
> Summary:	GNOME Cyrus-IMAPd Administrator
> Version:        0.3.3
> Release:	1%{?dist}
> License:	GPL
> Group:		Applications/Mail
> URL:		http://gyrus.gnome.cl/
> Source0:	%{name}-%{version}.tar.bz2
This should be an absolute URL pointing the source tarball.

> BuildPrereq:	GConf2-devel >= 2.0.0
> BuildPrereq:	gtk2-devel >= 2.4.0
> BuildPrereq:	libglade2-devel >= 2.0.0
> BuildPrereq:	libgnomeui-devel >= 2.6.0
> BuildPrereq:	gnet2-devel >= 2.0.0
BuildPrereq is an rpm anachronism. Using "BuildRequires:" instead is
preferred.

> Requires:	GConf2 >= 2.0.0
> Requires:	libglade2 >= 2.0.0
> Requires:	gnet2 >= 2.0.0
In general, most such Requires are superfluous - Please check.

> %makeinstall
Is this package using automake or libtool? 

Then, you will want to prefer using
make DESTDIR=%buildroot install

Ralf